This is really good, and in particular, I would never use Go's encoding/xml for anything security-sensitive. blog.trailofbits.com/2025/06/17/u...
9 reposts23 likes
This is really good, and in particular, I would never use Go's encoding/xml for anything security-sensitive. blog.trailofbits.com/2025/06/17/u...
9 reposts23 likes
encoding/xml is not a place of honor, and I am still hunting for someone to pay out of Geomys to make a SAML-oriented parser that doesn't suck. For encoding/json, sounds like /v2 fixes most of them, leaving json:"-,…" and json:"omitempty" for which I opened github.com/dominikh/go-...
I don't think that writing a new parser will ensure that SAML will be secure. The right approach is to refactor libraries to use only the signed contents, like you mentioned previously: bsky.app/profile/fili... bsky.app/profile/fili...
This writeup on a signature bypass vulnerability does a good job of calling out some design red flags, but I want to point out a major one. If you need to extract a signature out of a message, you MUST NEVER then operate on the original message. Many applications and protocols get this wrong.
Can you double check whether the patches use signed contents, and are secure (even if it relies on a vulnerable XML parser). github.com/russellhaeri... github.com/russellhaeri...
dont worry, there is is this popular alternative maintained by mailru: github.com/mailru/easyj...