Post

some notes parallel to @dholms.at: I'm confused why the commitment (integrity?) hash would not go in the header CBOR. I like having magic! and it being extensible. combining the "type" and "version" together in a single byte might work?

oh i realized after reading this that my comment on magic bytes might have been unclear i like the first three magic bytes! i'm just not sure about the 4th

i think one of two things: - it should reference the archive type not the commit type (so "s" for space instead of "L" for LtHash) - or the 4th byte can just be eliminated and that type of switching is handled in the header cbor rather than by the serialization format

yeah i forget why i didnt want to use “S” for space, but “L” was meant to mean “space” just keyed off the hash type for some reason (i have zero attachment to this!) four magic bytes was to have public and space repos under the same version byte. also not attached, and that goes away if we do

0 reposts5 likes